Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mentionable users fall back #1888

Merged
merged 7 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@vanessayuenn
Copy link
Contributor

vanessayuenn commented Jan 7, 2019

resolves #1872

If GithubLoginModel cannot retrieve mentionable users for whatever reason, we fall back to fill UserStore from recent git commit authors, so the co-author dropdown isn't left empty.

@vanessayuenn vanessayuenn requested review from atom/github-package and removed request for atom/github-package Jan 7, 2019

@vanessayuenn vanessayuenn changed the title mentionable users fall back [wip] mentionable users fall back Jan 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1888 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1888      +/-   ##
==========================================
- Coverage   91.22%   91.21%   -0.01%     
==========================================
  Files         196      196              
  Lines       10745    10747       +2     
  Branches     1574     1575       +1     
==========================================
+ Hits         9802     9803       +1     
- Misses        943      944       +1
Impacted Files Coverage Δ
lib/models/user-store.js 99.2% <100%> (+0.01%) ⬆️
lib/git-shell-out-strategy.js 87.52% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2fe2d...f982959. Read the comment docs.

@annthurium
Copy link
Contributor

annthurium left a comment

thanks for fixing this, @vanessayuenn !

Great example of writing just enough code to solve the problem.

Failing tests need to be fixed before merge, obvi, but other than that, ship it!

@vanessayuenn vanessayuenn changed the title [wip] mentionable users fall back mentionable users fall back Jan 8, 2019

@vanessayuenn vanessayuenn merged commit fda1aa0 into master Jan 8, 2019

2 checks passed

codecov/patch 100% of diff hit (target 91.22%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +8.77% compared to 7f2fe2d
Details

@vanessayuenn vanessayuenn deleted the vy/fall-back-gitlog-users branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.