Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Relay-generated GraphQL files from code coverage #1889

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@smashwilson
Copy link
Member

smashwilson commented Jan 8, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Exclude files generated by relay-compiler from collected code coverage.

Alternate Designs

I don't think there really is one.

Benefits

It'll make our code coverage go up 馃槈

Possible Drawbacks

We might accidentally add a file with a name matching *.graphql.js in a directory called __generated__ and exclude it by mistake... ?

Applicable Issues

Fixes #1886.

Metrics

N/A

Tests

N/A

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

smashwilson added some commits Jan 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #1889 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   91.21%   91.13%   -0.08%     
==========================================
  Files         196      185      -11     
  Lines       10747    10639     -108     
  Branches     1575     1575              
==========================================
- Hits         9803     9696     -107     
+ Misses        944      943       -1
Impacted Files Coverage 螖
...erated__/issueishListController_results.graphql.js
...ated__/prTimelineController_pullRequest.graphql.js
..._generated__/prStatusesView_pullRequest.graphql.js
...enerated__/issueishSearchContainerQuery.graphql.js
..._generated__/prStatusesViewRefetchQuery.graphql.js
...ated__/currentPullRequestContainerQuery.graphql.js
.../__generated__/prDetailView_pullRequest.graphql.js
...ners/__generated__/remoteContainerQuery.graphql.js
...enerated__/issueishDetailContainerQuery.graphql.js
...s/__generated__/prDetailView_repository.graphql.js
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fda1aa0...b8f1482. Read the comment docs.

@smashwilson smashwilson requested a review from atom/github-package Jan 8, 2019

@annthurium
Copy link
Contributor

annthurium left a comment

yay, thank you!!

@annthurium annthurium merged commit 75f37a4 into master Jan 8, 2019

2 checks passed

codecov/patch Coverage not affected when comparing fda1aa0...b8f1482
Details
codecov/project 91.13% (-0.08%) compared to fda1aa0
Details

@smashwilson smashwilson deleted the aw/exclude-graphql branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.