Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all of our dev dependencies in one fell swoop #1891

Merged
merged 1 commit into from Jan 9, 2019

Conversation

2 participants
@smashwilson
Copy link
Member

smashwilson commented Jan 8, 2019

This is me running through npm outdated and updating everything in devDependencies to @latest at once. Because these are all dev dependencies, a green build and proper coverage reporting are strong indicators that this is fine to do.

@smashwilson smashwilson added this to In Progress 🔧 in Sprint : 9 January 2019 - 12 February 2019 : v0.25.0 via automation Jan 8, 2019

@smashwilson smashwilson requested a review from atom/github-package Jan 9, 2019

Sprint : 9 January 2019 - 12 February 2019 : v0.25.0 automation moved this from In Progress 🔧 to QA Review 🔬 Jan 9, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #1891 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   91.07%   91.08%   +0.01%     
==========================================
  Files         185      185              
  Lines       10639    10719      +80     
  Branches     1575     1575              
==========================================
+ Hits         9689     9763      +74     
- Misses        950      956       +6
Impacted Files Coverage Δ
lib/views/pr-commits-view.js 58.33% <0%> (-8.34%) ⬇️
lib/models/author.js 66.03% <0%> (-6.69%) ⬇️
lib/models/operation-state-observer.js 97.14% <0%> (-2.86%) ⬇️
lib/models/commit.js 91.91% <0%> (-2.77%) ⬇️
lib/composite-git-strategy.js 100% <0%> (ø) ⬆️
lib/models/remote.js 100% <0%> (ø) ⬆️
lib/atom/uri-pattern.js 100% <0%> (ø) ⬆️
lib/controllers/issue-timeline-controller.js 0% <0%> (ø) ⬆️
lib/models/patch/file.js 100% <0%> (ø) ⬆️
lib/controllers/pr-timeline-controller.js 33.33% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a6f13...5a899aa. Read the comment docs.

@smashwilson smashwilson merged commit f3971dc into master Jan 9, 2019

2 checks passed

codecov/patch Coverage not affected when comparing 58a6f13...5a899aa
Details
codecov/project 91.08% (+0.01%) compared to 58a6f13
Details

Sprint : 9 January 2019 - 12 February 2019 : v0.25.0 automation moved this from QA Review 🔬 to Merged ☑️ Jan 9, 2019

@smashwilson smashwilson deleted the aw/dev-deps-up branch Jan 9, 2019

@kuychaco kuychaco referenced this pull request Feb 4, 2019

Closed

v0.25.0-0 QA Review #1936

14 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.