Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Test coverage for GitTempDir #1901
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Adds test coverage for
I could have only covered the lines that weren't hit by other codepaths, but it's a small class so I just covered the whole thing.
GitTempDir is one of the culprits in test coverage flapping that we see on unrelated PRs. This is one step toward minimizing those changes and keeping CodeCov output relevent.
This should raise GitTempDir's coverage to 100%.
User Experience Research (Optional)
added this to In Progress 🔧
in Sprint : 9 January 2019 - 12 February 2019 : v0.25.0
Jan 10, 2019
@@ Coverage Diff @@ ## master #1901 +/- ## ========================================== - Coverage 91.09% 91.05% -0.05% ========================================== Files 185 185 Lines 10719 10719 Branches 1575 1575 ========================================== - Hits 9765 9760 -5 - Misses 954 959 +5
Sprint : 9 January 2019 - 12 February 2019 : v0.25.0
moved this from In Progress 🔧
to QA Review 🔬
Jan 10, 2019
annthurium left a comment
thanks for making our test coverage more stable! I have a question or two for my own education but nothing blocking.
Why were these files causing flapping in the first place? Were there timing issues or something, where sometimes we met certain conditions and sometimes not?