Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Further improvements to "empty" views/modals #1928
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
This PR builds on #1927 and includes the following changes:
At the very least I would like to get the login modal rework merged; the rest is really up to discussion whether or not those changes are an improvement over the current look & feel.
Too many changes
Select a Remote
I guess we can just keep the original Git & Github icons everywhere. I thought that using icons which better represent the current context would improve users' understanding of what's going on without reading the text.
Some of the less-frequently used screens (Github login, multiple remotes selection view etc.) have received visual overhaul.
User Experience Research (Optional)
I love the other changes, but this one seems a little jarring. I would expect the dialogs to be consistently centered, and it also leaves a large amount of empty space above it.
@50Wliu Thanks for feedback! It just occurred to me that perhaps it would be better if we move the big icons consistently to the centre while preserving the buttons' placement?
Personally I like how the buttons "feel" when they are at the bottom - they seem to stick there regardless of viewport or pane size. If you align all the content to the middle the content seems to "travel" as you resize the viewport.
Here a screenshot:
I like the idea of keeping the buttons in a predictable place.. but the single icon looks a bit weird. Maybe if the icon would be some bigger illustration?
An argument for keeping it centered might be that the distance to travel with your mouse and eyes is somewhat "averaged" and using the tabs wouldn't penalize you to move all the way to the bottom:
Another idea: Have 1-3 words wrapped with
It's a bit like seeing a "404" on a website. After encountering this view a few times you might remember what it means and don't have to start reading from the start, you'll be like: "Ohh.. multiple remotes... ok!". The branch name would be wrapped with
Or have a title everywhere, like
@simurai Thanks for all the suggestions. I personally like the idea of having headings on all the views for quick summary of what's going on.
To somewhat address the concern of the buttons being too far away from the tabs, I added a significant margin to all the views with buttons to push the content up a bit - the views are still pushed down but they appear a little higher now (screenshots follow).
Also I increased the icons' size to make them more prominent.
Let me know your thoughts. If you still feel that the content should be centered I'll revert the placement back. Overall I like the other changes.
No problem @simurai, I have moved all the things to the pane's centre now.
I have updated the PR's initial description (incl. screenshots) in case you'd like to review again.
I also noticed that all the other dialog views with buttons use an "imperative tone" in the headings except for the "Multiple Remotes" view, so I changed that heading to "Select a Remote" which I think better conveys the view's purpose.