Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React upgrades #1956

Merged
merged 3 commits into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@smashwilson
Copy link
Member

smashwilson commented Feb 15, 2019

Hooooks

@smashwilson smashwilson requested a review from atom/github-package Feb 15, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #1956 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   92.13%   92.12%   -0.01%     
==========================================
  Files         188      188              
  Lines       10807    10807              
  Branches     1581     1581              
==========================================
- Hits         9957     9956       -1     
- Misses        850      851       +1
Impacted Files Coverage Δ
lib/github-package.js 68.09% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb874d...1fdc1bb. Read the comment docs.

greenkeeper[bot] added some commits Feb 14, 2019

@smashwilson smashwilson force-pushed the greenkeeper/monorepo.react-20190214204033 branch from f47c4e9 to 1fdc1bb Feb 19, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Feb 19, 2019

Gave this a shot in dev mode and it looks like we're rendering all clean 👍

@smashwilson smashwilson merged commit f3c973d into master Feb 20, 2019

2 checks passed

codecov/patch Coverage not affected when comparing ffb874d...1fdc1bb
Details
codecov/project 92.12% (-0.01%) compared to ffb874d
Details

@smashwilson smashwilson deleted the greenkeeper/monorepo.react-20190214204033 branch Feb 20, 2019

@vanessayuenn vanessayuenn referenced this pull request Mar 6, 2019

Closed

v0.27.0-0 QA Review #2005

7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.