Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keytar@4.4.0 #1967

merged 2 commits into from Feb 25, 2019


None yet
1 participant
Copy link

smashwilson commented Feb 19, 2019

Split off from #1942.


This comment has been minimized.

Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1967   +/-   ##
  Coverage   92.13%   92.13%           
  Files         188      188           
  Lines       10807    10807           
  Branches     1581     1581           
  Hits         9957     9957           
  Misses        850      850
Impacted Files Coverage Δ
lib/github-package.js 68.09% <0%> (-0.39%) ⬇️
lib/atom/gutter.js 92.3% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb874d...0670a24. Read the comment docs.

@smashwilson smashwilson requested a review from atom/github-package Feb 19, 2019


This comment has been minimized.

Copy link
Member Author

smashwilson commented Feb 25, 2019

Merging without review because it's a dependency bump 🤞

@smashwilson smashwilson merged commit e48cd98 into master Feb 25, 2019

2 checks passed

codecov/patch Coverage not affected when comparing ffb874d...0670a24
codecov/project 92.13% remains the same compared to ffb874d

@smashwilson smashwilson deleted the greenkeeper/keytar-4.4.0 branch Feb 25, 2019

@vanessayuenn vanessayuenn referenced this pull request Mar 6, 2019


v0.27.0-0 QA Review #2005

7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.