Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Relay 3.0.0 #1982

Merged
merged 13 commits into from Feb 26, 2019

Conversation

Projects
3 participants
@smashwilson
Copy link
Member

smashwilson commented Feb 25, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

We're suddenly two major versions behind the latest Relay. I'm shaving all of the yaks we need to get us back in sync again - it turns out that Relay 3 requires Babel 7, so I had to get @atom/babel7-transpiler up and running first.

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Bug fixes and new features. Easier to patch for security vulnerabilities later if we need to.

Possible Drawbacks

It could break something else.

Applicable Issues

Fixes #1976.
Fixes #1975.
Fixes #1974.

Metrics

N/A

Tests

I'll verify with a clean test run and a quick smoke test of the GitHub tab features.

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

smashwilson added some commits Feb 25, 2019

Upgrade Babel to Babel 6
Relay 3 needs Babel 7, so it's time for us to upgrade our transpilation 
pipeline.
Use a .babelrc.js file instead of a .babelrc
This lets us use `process.versions.electron` to magically transpile 
source appropriate to the actual Electron version we're running under.

smashwilson added some commits Feb 25, 2019

Show resolved Hide resolved package.json

smashwilson added some commits Feb 25, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #1982 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
+ Coverage   92.12%   92.13%   +<.01%     
==========================================
  Files         188      188              
  Lines       10807    10803       -4     
  Branches     1581     1581              
==========================================
- Hits         9956     9953       -3     
+ Misses        851      850       -1
Impacted Files Coverage Δ
lib/containers/issueish-search-container.js 95.83% <0%> (-0.17%) ⬇️
lib/containers/current-pull-request-container.js 95% <0%> (-0.13%) ⬇️
lib/containers/remote-container.js 100% <0%> (ø) ⬆️
lib/containers/issueish-detail-container.js 100% <0%> (ø) ⬆️
lib/github-package.js 68.48% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d67c14...68f8513. Read the comment docs.

smashwilson added some commits Feb 25, 2019

Explicitly enable object-rest-spread plugin
We need this because esprima, the JavaScript parser used by
electron-link, only supports ES2017, even though our current
Electron version supports some ES2018 features. Without this
plugin enabled, `npm run test:snapshot` fails with an esprima
error.
@vanessayuenn
Copy link
Contributor

vanessayuenn left a comment

🚀 🚀 waiting for em green builds! 🍏🥗📗

@smashwilson smashwilson marked this pull request as ready for review Feb 26, 2019

@smashwilson smashwilson merged commit 4932227 into master Feb 26, 2019

2 checks passed

codecov/patch Coverage not affected when comparing 2d67c14...68f8513
Details
codecov/project 92.13% (+<.01%) compared to 2d67c14
Details

Sprint : 13 February 2019 - 5 March 2019 : v0.27.0 automation moved this from In progress to Merged Feb 26, 2019

@smashwilson smashwilson deleted the aw/relay-up branch Feb 26, 2019

@vanessayuenn vanessayuenn referenced this pull request Mar 6, 2019

Closed

v0.27.0-0 QA Review #2005

7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.