Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new reaction emoji from GitHub.com #1985

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
2 participants
@annthurium
Copy link
Contributor

annthurium commented Feb 26, 2019

Description of the Change

GitHub.com now supports reaction emoji: 馃憖 and 馃殌 . Therefore, we should make sure these new emoji render when viewing pull requests and issues within Atom.

Also, now we don't render anything if the emoji is unrecognized. Hooray for graceful degradation.

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Emoji make subtext into text and enable remote communication and brings empathy into the development process. Letting our users use more kinds of emoji enables more communication modes.

Possible Drawbacks

Can't think of any.

Applicable Issues

#1916

Metrics

N/A

Tests

  • Wrote unit tests for the new emoji, graceful degradation
  • Manually rendered the issue that describes this problem (so meta) to verify the new emoji show up.

Documentation

N/A

Release Notes

  • The GitHub package now supports new reaction emoji: 馃憖 and 馃殌

User Experience Research (Optional)

N/A

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #1985 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
+ Coverage   92.12%   92.13%   +0.01%     
==========================================
  Files         188      188              
  Lines       10803    10806       +3     
  Branches     1581     1581              
==========================================
+ Hits         9952     9956       +4     
+ Misses        851      850       -1
Impacted Files Coverage 螖
lib/views/emoji-reactions-view.js 100% <100%> (酶) 猬嗭笍
lib/models/operation-states.js 91.66% <0%> (+2.08%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4932227...e11e687. Read the comment docs.

@annthurium annthurium requested a review from atom/github-package Feb 26, 2019

@smashwilson
Copy link
Member

smashwilson left a comment

馃憤 Hell yeah

@annthurium annthurium merged commit e2bc2ca into master Feb 26, 2019

2 checks passed

codecov/patch 100% of diff hit (target 92.12%)
Details
codecov/project 92.13% (+0.01%) compared to 4932227
Details

@annthurium annthurium deleted the tt-19-feb-emoji-support branch Feb 26, 2019

@vanessayuenn vanessayuenn referenced this pull request Mar 6, 2019

Closed

v0.27.0-0 QA Review #2005

7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.