Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit ID field from graphql query fragment #2003

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@kuychaco
Copy link
Member

kuychaco commented Mar 6, 2019

This field was not actually being used, and will apparently not be needed for calculating comment positioning any longer.

It also happened to be breaking our PR view due to a dotcom bug (see github/github#109043)

Remove commit ID field from graphql query fragment
Seems like this won't be needed after all since review comment positions seem to be based on the diff at the time of the query, not the time of the review
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #2003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2003   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files         189      189           
  Lines       11237    11237           
  Branches     1633     1633           
=======================================
  Hits        10403    10403           
  Misses        834      834
Impacted Files Coverage Δ
lib/containers/pr-reviews-container.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2abb6...73ba1e4. Read the comment docs.

@smashwilson
Copy link
Member

smashwilson left a comment

👍

@smashwilson smashwilson merged commit 690327e into master Mar 6, 2019

2 checks passed

codecov/patch Coverage not affected when comparing bf2abb6...73ba1e4
Details
codecov/project 92.57% remains the same compared to bf2abb6
Details

@smashwilson smashwilson deleted the ku-remove-commit-id-field branch Mar 6, 2019

@vanessayuenn vanessayuenn referenced this pull request Mar 6, 2019

Closed

v0.27.0-0 QA Review #2005

7 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.