Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a bunch of low-risk stuff at once #2050

Merged
merged 3 commits into from Apr 8, 2019

Conversation

Projects
2 participants
@smashwilson
Copy link
Member

commented Apr 8, 2019

Fixes #2020.
Fixes #2029.
Fixes #2034.
Fixes #2035.
Fixes #2031.
Fixes #2033.

smashwilson added some commits Apr 8, 2019

@smashwilson smashwilson force-pushed the aw/greenkeeper-omnibus branch from 622ae1f to 616dbd1 Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #2050 into master will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
+ Coverage   92.18%   92.54%   +0.35%     
==========================================
  Files         207      207              
  Lines       12010    12010              
  Branches     1745     1745              
==========================================
+ Hits        11072    11115      +43     
+ Misses        938      895      -43
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 100% <0%> (+0.19%) ⬆️
lib/helpers.js 89.95% <0%> (+4.36%) ⬆️
lib/models/file-system-change-observer.js 96% <0%> (+8%) ⬆️
lib/git-temp-dir.js 100% <0%> (+9.09%) ⬆️
lib/shared/keytar-strategy.js 58.13% <0%> (+19.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb06f2...4404756. Read the comment docs.

@vanessayuenn vanessayuenn merged commit 54a9b42 into master Apr 8, 2019

2 checks passed

codecov/patch Coverage not affected when comparing bbe8d31...4404756
Details
codecov/project 92.54% (+0.35%) compared to bbe8d31
Details

@vanessayuenn vanessayuenn deleted the aw/greenkeeper-omnibus branch Apr 8, 2019

@smashwilson smashwilson referenced this pull request Apr 8, 2019

Closed

v0.28.0-0 QA Review #2051

3 of 3 tasks complete

@smashwilson smashwilson added this to In progress in Sprint : 7 March 2019 - 3 April 2019 : v0.28.0 via automation Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.