Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate that comment has been edited #2057

Merged
merged 15 commits into from Apr 12, 2019
Merged

Indicate that comment has been edited #2057

merged 15 commits into from Apr 12, 2019

Conversation

@kuychaco
Copy link
Contributor

@kuychaco kuychaco commented Apr 10, 2019

Now that we've shipped review comments we'll want to let folks know when a comment was edited. This was brought to our attention by the community and safety team, with respect to the fact that nasty comments can be edited.

While Dotcom shows the full edit history, we decided to simply indicate that the comment was edited and link the user to Dotcom where they can view more context if they would like to.

See #2056 for reference.

edited comment (modeled after dotcom):
Screen Shot 2019-04-10 at 4 01 15 PM

edited review:
Screen Shot 2019-04-10 at 4 35 36 PM

Alternate designs

I explored a visual treatment where we use a badge instead of bullet-separated text. It felt maybe a bit too visually overwhelming imo, in an already busy design.

Screen Shot 2019-04-10 at 3 59 14 PM

lib/views/reviews-view.js Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Apr 10, 2019

Codecov Report

Merging #2057 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2057      +/-   ##
==========================================
+ Coverage   92.54%   92.55%   +<.01%     
==========================================
  Files         207      207              
  Lines       12010    12014       +4     
  Branches     1745     1746       +1     
==========================================
+ Hits        11115    11119       +4     
  Misses        895      895
Impacted Files Coverage Δ
...ainers/accumulators/review-comments-accumulator.js 100% <ø> (ø) ⬆️
...iners/accumulators/review-summaries-accumulator.js 100% <ø> (ø) ⬆️
lib/views/reviews-view.js 82.5% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79489ce...2636d70. Read the comment docs.

@kuychaco kuychaco requested a review from Apr 12, 2019
Copy link
Contributor

@annthurium annthurium left a comment

looks great, @kuychaco ! Thanks for getting this out so quickly.

@annthurium annthurium merged commit 1cd0bf6 into master Apr 12, 2019
14 checks passed
@annthurium annthurium deleted the ku-edited-badge branch Apr 12, 2019
smashwilson added a commit that referenced this issue May 8, 2019
Indicate that comment has been edited
@smashwilson smashwilson mentioned this pull request May 8, 2019
11 tasks
@smashwilson smashwilson mentioned this pull request May 8, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants