Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide alt text when committer's avatar fails to load #2066

Merged
merged 1 commit into from Apr 15, 2019

Conversation

2 participants
@rkbhochalya
Copy link
Contributor

commented Apr 15, 2019

Description of the Change

When we start Atom with no internet connectivity, committer's email address is shown in the place of committer's avatar in recent comments list in Git pane, which overlaps git messages and makes them hard to read. I have hidden alt text setting text color to transparent and overflow to hidden for the image element. This leaves an empty box instead of showing committer's email address when avatar fails to load and doesn't make any visual change when avatar is visible.

Screenshot/Gif

image

image

Alternate Designs

Alternatively we can show a default avatar but I went for just hiding the alt text as it was easy to implement.

Benefits

Commits list no longer looks weird when Atom is started with no internet.

Possible Drawbacks

Nothing I can think of.

Applicable Issues

#1528

Metrics

N/A

Tests

N/A

Documentation

N/A

Release Notes

Fixed an issue where committer's email address is shown in the place of committer's avatar when Atom is started with no internet connection.

Hide alt text when committer's avatar fails to load
This leaves an empty space instead of showing committer's email address when Atom is started with no internet connection.

Closes #1528
@smashwilson
Copy link
Member

left a comment

Oh cool! Thanks for taking care of this 🙇

@smashwilson smashwilson added this to In progress in Sprint : 7 March 2019 - 3 April 2019 : v0.28.0 via automation Apr 15, 2019

@smashwilson smashwilson merged commit e0b2853 into atom:master Apr 15, 2019

12 checks passed

atom.github Build #20190415.1 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details

Sprint : 7 March 2019 - 3 April 2019 : v0.28.0 automation moved this from In progress to Merged Apr 15, 2019

@rkbhochalya rkbhochalya deleted the rkbhochalya:rkbhochalya-fix-broken-avatar branch Apr 15, 2019

@smashwilson smashwilson added this to In progress in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 via automation May 8, 2019

@smashwilson smashwilson moved this from In progress to Merged in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 May 8, 2019

smashwilson added a commit that referenced this pull request May 8, 2019

Merge pull request #2066 from rkbhochalya/rkbhochalya-fix-broken-avatar
Hide alt text when committer's avatar fails to load

This was referenced May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.