Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist a bunch of dependencies (or: Let's Trust Bots To Not Mess Things Up) #2072

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
2 participants
@vanessayuenn
Copy link
Contributor

commented Apr 15, 2019

These are the "safest" dependencies to update automatically -- they are only used in tests, so we can trust that as long as tests are passing in CI, they should be good to merge.

whitelist a bunch of dependencies (mostly only used in tests) to allo…
…w dependabot to auto-merge these updates

@vanessayuenn vanessayuenn requested a review from atom/github-package Apr 15, 2019

@smashwilson
Copy link
Member

left a comment

Yessss. Trust the robots 🤖

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #2072 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files         207      207           
  Lines       12014    12014           
  Branches     1746     1746           
=======================================
  Hits        11119    11119           
  Misses        895      895

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffd964...f0abe40. Read the comment docs.

@vanessayuenn vanessayuenn merged commit 8423c02 into master Apr 15, 2019

14 checks passed

atom.github Build #20190415.26 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing 7ffd964...f0abe40
Details
codecov/project 92.55% remains the same compared to 7ffd964
Details

@vanessayuenn vanessayuenn deleted the vy/dependabot-config branch Apr 15, 2019

@smashwilson smashwilson referenced this pull request May 8, 2019

Closed

v0.29.0-0 QA Review #2129

11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.