Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill some metadata for report abuse link in review comments #2074

Merged
merged 3 commits into from Apr 17, 2019

Conversation

Projects
2 participants
@vanessayuenn
Copy link
Contributor

commented Apr 15, 2019

A piece of the feedback (#2056) we got from community & safety audit for the recently shipped review comments feature (#1995) suggests that the "report abuse" link in the review comment should include some metadata, so that important info can be prefilled.

@vanessayuenn vanessayuenn requested a review from atom/github-package Apr 15, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 15, 2019

Codecov Report

Merging #2074 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   92.55%   92.55%   +<.01%     
==========================================
  Files         207      207              
  Lines       12014    12016       +2     
  Branches     1746     1745       -1     
==========================================
+ Hits        11119    11121       +2     
  Misses        895      895
Impacted Files Coverage Δ
lib/views/reviews-view.js 82.71% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8423c02...f858cc5. Read the comment docs.

Show resolved Hide resolved lib/views/reviews-view.js Outdated

@vanessayuenn vanessayuenn requested a review from annthurium Apr 16, 2019

@annthurium
Copy link
Contributor

left a comment

lgtm, thanks for addressing this!

It might be good to have a unit testing asserting that the query string params are part of the link, but ehh, I don't feel strongly enough about it to block merging.

Show resolved Hide resolved lib/views/reviews-view.js

@vanessayuenn vanessayuenn merged commit 9421207 into master Apr 17, 2019

14 checks passed

atom.github Build #20190416.12 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch 100% of diff hit (target 92.55%)
Details
codecov/project 92.55% (+<.01%) compared to 8423c02
Details

@smashwilson smashwilson referenced this pull request May 8, 2019

Closed

v0.29.0-0 QA Review #2129

11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.