Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Additional entry point for review comments #2084
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
We received feedback asking to save users clicks when looking at reviews for non-checked out branches. See #2077.
This PR enables users to access reviews for any PR listed in the GitHub tab (not just the checked out PR) via a "See reviews" context menu item.
I also took this opportunity to add a quick way to view the PR on dotcom via a "View on GitHub" context menu item.
Initially considered hiding the option behind a right-click context menu, but figured adding a kebab icon would make this more discoverable. The drawback is that the icon takes up some UI real-estate, but in my opinion it's small and discreet enough that it's fine. Open to feedback and other suggestions.
Currently, it is only possible to view review comments for the checked out PR from the PR list.
In order to view review comments for a PR that is not checked out the user has to click the desired PR in the PR list to open the PR detail pane item, open the "Files" tab, and click the "See reviews" button in the footer of the tab.
With this change, we increase consistency by allowing the user to open reviews for any PR directly from the PR list. Previously this was only possible for the checked out PR.
None really... the only mild concern is that the additional icon might increase visual noise.
Adding an event for 'open-reviews-tab'.
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #2084 +/- ## ========================================== + Coverage 92.55% 92.55% +<.01% ========================================== Files 207 207 Lines 12016 12025 +9 Branches 1745 1747 +2 ========================================== + Hits 11121 11130 +9 Misses 895 895