Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add author association to review summaries and thread comments #2085
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Our trusty Community and Safety team pointed out that displaying "first time contributor" badges encourages people to be kind to new folks, etc.
This PR introduces
Badges for author association are displayed on review summary comments as well as review thread comments.
See #2056 for reference.
None were considered.
Folks have more context about the author of the comments and can therefore adjust their responses accordingly. For example, responses to comments made by "First-time contributors" warrant extra thought and attention, to ensure that we are welcoming new contributors and effectively growing our communities -- https://github.blog/2017-07-25-making-it-easier-to-grow-communities-on-github/
There is limited space in comment headers. An additional badge adds some visual noise, and if the panel width isn't large enough, the badge appears on a separate line:
Added unit tests to ensure that text shows up correctly for each author association value (member, owner, collaborator, contributor, first-time contributor, first-timer, none). Did this for both review summary comments and thread comments.
User Experience Research (Optional)
TODO: make summary badges drop to new line (as is the case for thread comments)
@@ Coverage Diff @@ ## master #2085 +/- ## ========================================== + Coverage 92.55% 92.55% +<.01% ========================================== Files 207 207 Lines 12016 12021 +5 Branches 1745 1746 +1 ========================================== + Hits 11121 11126 +5 Misses 895 895