Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow :/ in remote URL #2086

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
3 participants
@tjbenator
Copy link
Contributor

commented Apr 19, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Changed regex to allow for :/ in the remote URL:
git@github.com:/atom/github.git
ssh://git@github.com:/atom/github.git

This may fix issues some have had in #1010

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

This will allow the following remote URLs and enable login to github:
git@github.com:/atom/github.git
ssh://git@github.com:/atom/github.git

Possible Drawbacks

I can't think of any

Applicable Issues

Metrics

N/A

Tests

I added the additional URLs to the models/remote.test.js. No new tests needed. I also verified the remote URL worked in git with a git pull

Documentation

N/A

Release Notes

Allows :/ in ssh/git URLs

User Experience Research (Optional)

@annthurium
Copy link
Contributor

left a comment

thanks for taking a stab at this, @tjbenator !

looks good to me.

We have a team policy that community pull requests should be reviewed by 2 core team members, so I'll wait for a second approval before merging.

@smashwilson
Copy link
Member

left a comment

👍 Looks good to me. And thanks for adding tests 😄

@smashwilson smashwilson merged commit 51b13ae into atom:master Apr 23, 2019

12 checks passed

atom.github Build #20190419.7 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details

@smashwilson smashwilson added this to In progress in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 via automation May 8, 2019

@smashwilson smashwilson moved this from In progress to Merged in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 May 8, 2019

@smashwilson smashwilson referenced this pull request May 8, 2019

Closed

v0.29.0-0 QA Review #2129

11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.