Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass destroyed TextEditors to find-and-replace #2105

Merged
merged 7 commits into from Apr 30, 2019

Conversation

Projects
2 participants
@smashwilson
Copy link
Member

commented Apr 29, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Within items that embed TextEditors (ChangedFileItem, CommitDetailItem, CommitPreviewItem, and IssueishDetailItem), avoid triggering the observeEmbeddedTextEditor callback used by find-and-replace with TextEditors that have already been destroyed.

Screenshot

N/A

Alternate Designs

N/A

Benefits

Fixes a stack trace.

Possible Drawbacks

N/A

Applicable Issues

Fixes #2073.

Metrics

N/A

Tests

Augmented existing test suite to cover destroyed-editor cases.

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

smashwilson added some commits Apr 29, 2019

@smashwilson smashwilson self-assigned this Apr 29, 2019

@smashwilson smashwilson added this to In progress in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 via automation Apr 29, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 29, 2019

Codecov Report

Merging #2105 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
+ Coverage   92.55%   92.55%   +<.01%     
==========================================
  Files         207      207              
  Lines       12021    12025       +4     
  Branches     1746     1754       +8     
==========================================
+ Hits        11126    11130       +4     
  Misses        895      895
Impacted Files Coverage Δ
lib/items/commit-preview-item.js 100% <100%> (ø) ⬆️
lib/items/commit-detail-item.js 100% <100%> (ø) ⬆️
lib/items/issueish-detail-item.js 98.38% <100%> (+0.02%) ⬆️
lib/items/changed-file-item.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef8aac...bd6fe2c. Read the comment docs.

@smashwilson smashwilson requested a review from atom/github-package Apr 29, 2019

@kuychaco
Copy link
Member

left a comment

Nice fix and cleanup

@smashwilson smashwilson merged commit e93cd81 into master Apr 30, 2019

14 checks passed

atom.github Build #20190429.10 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch 100% of diff hit (target 92.55%)
Details
codecov/project 92.55% (+<.01%) compared to 4ef8aac
Details

Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 automation moved this from In progress to Merged Apr 30, 2019

@smashwilson smashwilson deleted the aw/destroyed-marker-layers branch Apr 30, 2019

smashwilson added a commit that referenced this pull request May 8, 2019

Merge pull request #2105 from atom/aw/destroyed-marker-layers
Don't pass destroyed TextEditors to find-and-replace

This was referenced May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.