Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Exclude deprecated fields from the fetched schema #2107
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Inline the introspectionQuery from the graphql package and change the
It might be worth making a pull request to the GraphQL package itself to give
Early notice of GraphQL schema changes that will affect us. This would help prevent regressions like #2094 from occurring.
Well... we can't actually merge the schema changes until #2104 is merged
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #2107 +/- ## ======================================= Coverage 92.55% 92.55% ======================================= Files 207 207 Lines 12021 12021 Branches 1746 1746 ======================================= Hits 11126 11126 Misses 895 895
kuychaco left a comment
This looks good to me
I guess it's technically somewhat redundant to #2108, but still seems like a good change!
A couple quick questions to consider before merging:
@smashwilson you indicated
I'm also wondering if there is a way to programmatically modify the
Yeah, kind of? There's likely a way to share code between them once they're both merged, even.
Oh, right, I did check it out manually - I didn't commit the schema changes it made because they broke relay-compiler on account of #2104 not being merged yet.
Oh, interesting idea... I'd thought about sending a pull request to the GraphQL package to add a