Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved GitHub tab blank-slate behavior #2111

Merged
merged 16 commits into from Nov 15, 2019
Merged

Improved GitHub tab blank-slate behavior #2111

merged 16 commits into from Nov 15, 2019

Conversation

@smashwilson
Copy link
Member

smashwilson commented May 1, 2019

The current behavior of the GitHub tab when you have no repository or a repository with no GitHub remotes is really unhelpful: we either show a blank tab or a message saying "no remotes" that you can't do anything about until you go to the command line. We also don't have good support for the fairly common scenario where a user wants to push new branches to a different remote than the one they want to see pull requests from (say, when they've forked an open-source repository to contribute).

I'd like to redesign the GitHub tab's "empty" states to be more friendly, informative and actionable.

Prototypes

To access the prototypes I've used to create the screenshots in this feature request, check out the branch prototypes/aw/blank-slate, then:

  • For the GitHub tab blank states: Open the GitHub package settings in the Settings view. Find the "Prototype scenario" setting and choose a value other than "none" to see the different mocks.
  • For the dialog mocks: Run one of the following commands from the command palette. Focus the dialog and press esc to dismiss.
    • github:proto-clone-dialog-empty-search
    • github:proto-clone-dialog-search-results
    • github:proto-clone-dialog-github
    • github:proto-clone-dialog-nongithub
    • github:proto-create-dialog
    • github:proto-publish-dialog

View rendered docs/feature-requests/005-blank-slate.md

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #2111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2111   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         219      219           
  Lines       12322    12322           
  Branches     1793     1793           
=======================================
  Hits        11429    11429           
  Misses        893      893

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8aa3b8...c9925e3. Read the comment docs.

smashwilson added 4 commits May 2, 2019
@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented May 2, 2019

Note to self: I should add an https/git protocol toggle to the clone and connect dialogs.

smashwilson added 4 commits May 6, 2019
@smashwilson smashwilson marked this pull request as ready for review May 6, 2019
@smashwilson smashwilson requested a review from atom/github-package May 6, 2019
@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented May 6, 2019

I think this is ready for more eyes 👀

Copy link
Contributor

vanessayuenn left a comment

Thank you for writing this up @smashwilson ! A lot of use cases are covered and is very thoroughly thought out. Since the main objective of this feature is to make it easier for users who are unfamiliar with git/GitHub workflow to get started, I think keeping any new UI and workflow simple would be crucial. I suggested some ways to further simplify the UI, as well as my thoughts on excluding the forking workflow on this iteration.

docs/feature-requests/005-blank-slate.md Outdated Show resolved Hide resolved
docs/feature-requests/005-blank-slate.md Show resolved Hide resolved
docs/feature-requests/005-blank-slate.md Show resolved Hide resolved
docs/feature-requests/005-blank-slate.md Outdated Show resolved Hide resolved
docs/feature-requests/005-blank-slate.md Outdated Show resolved Hide resolved
docs/feature-requests/005-blank-slate.md Show resolved Hide resolved
docs/feature-requests/005-blank-slate.md Show resolved Hide resolved
@smashwilson smashwilson added this to In progress in Release : 9 May 2019 - 5 June 2019 : v0.30.0 via automation May 8, 2019
smashwilson added 5 commits Jul 12, 2019
@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Jul 16, 2019

Thanks for the feedback, @vanessayuenn! As usual the UX is feeling worlds better after your comments 😁

@smashwilson smashwilson mentioned this pull request Jul 17, 2019
5 of 5 tasks complete
@smashwilson smashwilson mentioned this pull request Jul 23, 2019
18 of 18 tasks complete
@smashwilson smashwilson mentioned this pull request Nov 6, 2019
4 of 4 tasks complete
@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Nov 15, 2019

I'm going to punt on the clone dialog enhancements, at least for now. It feels like searching for repos in Atom wouldn't be as much of a high-demand operation... pasting in a clone URL isn't that bad, for the additional complexity of the new dialog I was thinking about.

Calling this otherwise complete 🎉

@smashwilson smashwilson reopened this Nov 15, 2019
@smashwilson smashwilson merged commit 0b19e6d into master Nov 15, 2019
4 of 9 checks passed
4 of 9 checks passed
Consider pull request for release board Consider pull request for release board
Details
atom.github (Lint) Lint failed
Details
atom.github (Linux) Linux failed
Details
atom.github (MacOS) MacOS failed
Details
atom.github (Snapshot) Snapshot failed
Details
atom.github (Windows) Windows failed
Details
atom.github Build #20190723.5 succeeded
Details
codecov/patch Coverage not affected when comparing b8aa3b8...c9925e3
Details
codecov/project 92.75% remains the same compared to b8aa3b8
Details
@smashwilson smashwilson deleted the aw/fr/blank-slate branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.