Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add `NODE_ENV=development` to `test` script to see React errors #2113
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
This PR sets our
Rationale: React runs fewer checks in production mode for efficiency. For example, in development mode it checks that props have not been mutated but in production mode it seems that it does not. We had an issue where tests were failing on CI due to mutated props but not locally until we set the NODE_ENV to be development. Presumably our CI is running with development mode by default. Let's just have this always be the case to err on the side of catching more errors locally.
Catch bugs more easily / faster!
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #2113 +/- ## ========================================== + Coverage 92.65% 92.66% +<.01% ========================================== Files 207 207 Lines 12045 12045 Branches 1764 1764 ========================================== + Hits 11160 11161 +1 + Misses 885 884 -1