Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap button colors to emphasize `Comment` more than `Resolve Conversa… #2115

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
2 participants
@vanessayuenn
Copy link
Contributor

commented May 1, 2019

I kept clicking "Resolve conversation" instead of "Comment" by accident, because the bright color of btn-primary called to me. This PR swaps the colors of those two buttons, since "Comment" is more likely to be the button a user means to click.

@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #2115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2115   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files         207      207           
  Lines       12045    12045           
  Branches     1764     1764           
=======================================
  Hits        11160    11160           
  Misses        885      885
Impacted Files Coverage Δ
lib/views/reviews-view.js 83.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b569d0...e9257a5. Read the comment docs.

@vanessayuenn vanessayuenn merged commit a36da88 into master May 2, 2019

14 checks passed

atom.github Build #20190501.37 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing 9b569d0...e9257a5
Details
codecov/project 92.65% remains the same compared to 9b569d0
Details

@vanessayuenn vanessayuenn deleted the vy/swap-review-buttons-order branch May 2, 2019

@smashwilson smashwilson added this to In progress in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 via automation May 8, 2019

@smashwilson smashwilson moved this from In progress to Merged in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 May 8, 2019

@smashwilson smashwilson referenced this pull request May 8, 2019

Closed

v0.29.0-0 QA Review #2129

11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.