Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Group resolved comments #2117
Description of the Change
I experimented with using filter toggle but the user experience feels clunky, and with the current design, there isn't really a natural placement for the toggle.
Resolved comments are moved out of the way, further encouraging the use of review comments as a to-do list behaviour model.
It might confuse users slightly when the resolved comment gets moved to another location. The highlighting should mitigate this confusion, but the problem can still exist for cases where there are many comments. However, the current implementation of collapsing comments immediately after resolving is probably just as confusing, so I don't see this feature making the experience worse.
TBD: still working on them!
Group resolved review comments into its own list.
@@ Coverage Diff @@ ## master #2117 +/- ## ========================================== - Coverage 92.65% 92.63% -0.02% ========================================== Files 207 207 Lines 12045 12040 -5 Branches 1764 1747 -17 ========================================== - Hits 11160 11153 -7 - Misses 885 887 +2