Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default upstream refspec to master #2125

Merged
merged 3 commits into from May 6, 2019

Conversation

Projects
1 participant
@smashwilson
Copy link
Member

commented May 6, 2019

The first scheduled run of our schema-up action failed on master:

ℹ  info      Fetching the latest GraphQL schema changes.
ℹ  info      Committing schema changes.
ℹ  info      Re-running relay compiler.
ℹ  info      Relay output:

Writing js
Unchanged: 62 files
ℹ  info      Generated relay files are unchanged.
✖  fatal     TypeError: Cannot read property 'replace' of undefined 
    at Toolkit.run (/index.js:45:40)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

### FAILED Update schema 01:01:22Z (21.425s)

I'd assumed that toolkit.context.ref would be populated with the repository's default branch when run from a schedule trigger, but this is not the case:

The branch or tag ref that triggered the workflow. For example, refs/heads/feature-branch-1. If neither a branch or tag is available for the event type, the variable will not exist.

The easiest fix here is to default to master.

smashwilson added some commits May 6, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

I'm also changing the scheduled weekday to Tuesday so we'll have a chance to see if it works tonight rather than waiting an entire week.

@codecov

This comment has been minimized.

Copy link

commented May 6, 2019

Codecov Report

Merging #2125 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2125      +/-   ##
==========================================
- Coverage   92.66%   92.65%   -0.01%     
==========================================
  Files         207      207              
  Lines       12045    12045              
  Branches     1764     1764              
==========================================
- Hits        11161    11160       -1     
- Misses        884      885       +1
Impacted Files Coverage Δ
lib/atom/gutter.js 89.74% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23324dd...0475033. Read the comment docs.

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

Self-merging because there's no way to know if this will work or not until it's on master 🎶

@smashwilson smashwilson merged commit 236bebb into master May 6, 2019

14 checks passed

atom.github Build #20190506.6 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing 23324dd...0475033
Details
codecov/project 92.65% (-0.01%) compared to 23324dd
Details

@smashwilson smashwilson deleted the aw/no-ref-on-master branch May 6, 2019

@smashwilson smashwilson added this to In progress in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 via automation May 8, 2019

@smashwilson smashwilson moved this from In progress to Merged in Sprint : 4 April 2019 - 8 May 2019 : v0.29.0 May 8, 2019

@smashwilson smashwilson referenced this pull request May 8, 2019

Closed

v0.29.0-0 QA Review #2129

11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.