Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve error handling when offline #2128
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
When the network is unavailable, the GitHub package behaves poorly:
When a user attempts to open a new item that uses Relay data (an issueish detail item, the reviews tab) while the network is offline, including items created during window state deserialization (like a reload):
When a user attempts to click a refresh button or perform a mutation while offline:
When the network dies in between the git fetch completing and the Relay refetch triggering somehow:
Users on spotty wi-fi or airplanes can have a gracefully degraded Atom experience and informative error states.
The errors thrown by the
I did manual testing both by toggling network connectivity in the dev tools and by actually disabling and enabling wi-fi.
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #2128 +/- ## ========================================== + Coverage 92.53% 92.68% +0.14% ========================================== Files 212 213 +1 Lines 12171 12188 +17 Branches 1779 1788 +9 ========================================== + Hits 11263 11296 +33 + Misses 908 892 -16
vanessayuenn left a comment
Thanks for tackling this! The new offline view looks good and the message is very clear