Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when offline #2128

Merged
merged 35 commits into from May 14, 2019
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
a261186
Deautobind ErrorView
smashwilson May 7, 2019
32ca80c
Render an "open dev tools" button in <ErrorView>
smashwilson May 7, 2019
c1bf750
Flag network errors
smashwilson May 7, 2019
d65d2f0
Special-case network errors in QueryErrorView
smashwilson May 7, 2019
fdfaedb
Deautobind GitHubTabContainer
smashwilson May 7, 2019
7e374e1
Deautobind RemoteContainer
smashwilson May 7, 2019
37ea727
Deautobind GitHubTabController
smashwilson May 7, 2019
599dde1
Drill openDevTools everywhere
smashwilson May 7, 2019
8d06698
Rearrange ErrorView buttons
smashwilson May 7, 2019
a96dfd0
Missed a drilling spot
smashwilson May 7, 2019
8df7ed4
Return a distinct OFFLINE case when the fetch fails
smashwilson May 8, 2019
993b78a
OfflineView to show when we're... offline
smashwilson May 8, 2019
3139f03
Handle the Offline case in IssueishDetailContainer
smashwilson May 8, 2019
9cf844c
No-op the OFFLINE case in CommentDecorationsContainer
smashwilson May 8, 2019
9a6fd11
Handle the Offline case in RemoteContainer
smashwilson May 8, 2019
069ec5e
Handle the Offline case in ReviewsContainer
smashwilson May 8, 2019
46fa12d
Handle the Offline case in UserStore
smashwilson May 8, 2019
743b5a9
Trigger a login model update when the network availability changes
smashwilson May 8, 2019
e53f3de
Use the OfflineView for network errors in QueryErrorView
smashwilson May 8, 2019
244deb2
Revert "Drill openDevTools everywhere"
smashwilson May 8, 2019
8d7d51f
Revert "Missed a drilling spot"
smashwilson May 8, 2019
fe7fe1a
Go home `git revert` you're drunk
smashwilson May 8, 2019
87e8e8f
Return a full Error instead of a special OFFLINE token
smashwilson May 8, 2019
154cbca
Okay we actually do want to throw those
smashwilson May 8, 2019
1f5c9e7
Special-case network errors in the QueryErrorTile
smashwilson May 9, 2019
1ad5547
Rename "reportMutationErrors" to "reportRelayError" globally :see_no_…
smashwilson May 9, 2019
c37dd7a
Notify on refetch errors throughout the package
smashwilson May 9, 2019
d905027
Missed a prop
smashwilson May 9, 2019
8b7ccbe
Custom handling of network errors in the Relay error callback
smashwilson May 9, 2019
d29884d
:fire: unused openDevTools prop
smashwilson May 13, 2019
8410a12
Merge branch 'master' of github.com:atom/github into aw/die-better-wh…
smashwilson May 14, 2019
8450081
ErrorView test coverage :100:
smashwilson May 14, 2019
2fcb19b
QueryErrorView test coverage :100:
smashwilson May 14, 2019
1cffb72
Okay just skip that whole describe()
smashwilson May 14, 2019
8b47553
Test RootController::reportRelayError()
smashwilson May 14, 2019
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Revert "Missed a drilling spot"

This reverts commit 0b3959a.
  • Loading branch information...
smashwilson committed May 8, 2019
commit 8d7d51fb063793e056232e103a9e4a1d2bf2b79d
@@ -120,7 +120,6 @@ export default class IssueishDetailItem extends Component {
keymaps={this.props.keymaps}
tooltips={this.props.tooltips}
config={this.props.config}
openDevTools={this.props.openDevTools}

destroy={this.destroy}
itemType={this.constructor}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.