Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issues and pull requests to the current release project #2131

Merged
merged 12 commits into from May 14, 2019

Conversation

@smashwilson
Copy link
Member

commented May 8, 2019

More GitHub Action fun ⚡️

This one will run each time we assign an issue or open a pull request. It'll add the issue or pull request to the current release project board so we keep that as an accurate record of the work that's been done within each release cycle.

smashwilson added some commits May 7, 2019

@smashwilson smashwilson added this to In progress in Release : 9 May 2019 - 5 June 2019 : v0.30.0 via automation May 8, 2019

@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2131 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2131      +/-   ##
==========================================
+ Coverage   92.72%   92.73%   +<.01%     
==========================================
  Files         207      207              
  Lines       12053    12053              
  Branches     1764     1764              
==========================================
+ Hits        11176    11177       +1     
+ Misses        877      876       -1
Impacted Files Coverage Δ
lib/models/operation-states.js 91.66% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131afd2...38e6200. Read the comment docs.

smashwilson added some commits May 8, 2019

smashwilson added some commits May 8, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

Tested with #2132. Looks like it added itself to the release project correctly ⚡️

@smashwilson smashwilson marked this pull request as ready for review May 8, 2019

@smashwilson smashwilson requested a review from atom/github-package May 8, 2019

@vanessayuenn
Copy link
Contributor

left a comment

Excited to see how this will work! Something that would be neat is to add an action triggered by us unassigning issues, which will take the issue off the current project board. It's just an 💡 idea 💡 though.

query {
repository(owner: "atom", name: "github") {
projects(
search: "Release"

This comment has been minimized.

Copy link
@vanessayuenn

vanessayuenn May 13, 2019

Contributor

Will the matching be case sensitive, then? And is this search only on the name of the project board?

This comment has been minimized.

Copy link
@smashwilson

smashwilson May 14, 2019

Author Member

The search is only on the name of the board:

https://developer.github.com/v4/object/repository/, search for "projects"

Query to search projects by, currently only searching by name.

I'm not sure if it's case sensitive or not, though? The one I tested with was an exact case match 🤔

args = "action 'opened|merged|assigned|reopened'"
}

action "Add pull request to release board" {

This comment has been minimized.

Copy link
@vanessayuenn

vanessayuenn May 13, 2019

Contributor

How are "add" vs "consider" distinguished here?

This comment has been minimized.

Copy link
@smashwilson

smashwilson May 14, 2019

Author Member

Basically, "consider" filters on the event's action to determine whether or not it should result in a release board addition; "add" does the actual addition.

@smashwilson smashwilson merged commit edbb26d into master May 14, 2019

16 of 20 checks passed

Consider pull request for release board Consider pull request for release board
Details
Consider pull request for release board Consider pull request for release board
Details
Consider pull request for release board Consider pull request for release board
Details
Consider pull request for release board Consider pull request for release board
Details
Add pull request to release board Add pull request to release board
Details
Consider pull request for release board Consider pull request for release board
Details
atom.github Build #20190508.56 had test failures
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing 131afd2...38e6200
Details
codecov/project 92.73% (+<.01%) compared to 131afd2
Details

Release : 9 May 2019 - 5 June 2019 : v0.30.0 automation moved this from In progress to Merged May 14, 2019

@smashwilson smashwilson deleted the aw/auto-add-to-sprint branch May 14, 2019

@smashwilson smashwilson referenced this pull request Jul 18, 2019
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.