Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always create a pull request for schema changes #2133

Merged
merged 4 commits into from May 8, 2019

Conversation

@smashwilson
Copy link
Member

commented May 8, 2019

The less-intrusive "push schema changes directly to master" flow I was hoping to support is now failing because it can't bypass the branch protections to push:

Check run

ℹ  info      Fetching the latest GraphQL schema changes.
ℹ  info      Committing schema changes.
ℹ  info      Re-running relay compiler.
ℹ  info      Relay output:

Writing js
Unchanged: 62 files
ℹ  info      Generated relay files are unchanged.
✖  fatal     Error: Command failed: git push origin HEAD:refs/heads/master 
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: 12 of 12 required status checks are expected.        
To https://github.com/atom/github.git
 ! [remote rejected]   HEAD -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/atom/github.git'


    at makeError (/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/node_modules/execa/index.js:278:16)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

I'm modifying the Action to always create a pull request, even if relay-compiler didn't change everything. One autogenerated PR per week shouldn't be too bad.

smashwilson added some commits May 8, 2019

@smashwilson

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

Tested out on a temporary branch; output here.

@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #2133 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   92.72%   92.68%   -0.05%     
==========================================
  Files         207      207              
  Lines       12053    12053              
  Branches     1764     1764              
==========================================
- Hits        11176    11171       -5     
- Misses        877      882       +5
Impacted Files Coverage Δ
lib/git-temp-dir.js 90.9% <0%> (-9.1%) ⬇️
lib/helpers.js 88.69% <0%> (-1.31%) ⬇️
lib/models/operation-states.js 91.66% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131afd2...18197f1. Read the comment docs.

@smashwilson smashwilson merged commit 8d39c1f into master May 8, 2019

14 checks passed

atom.github Build #20190508.51 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing 131afd2...18197f1
Details
codecov/project 92.68% (-0.05%) compared to 131afd2
Details

@smashwilson smashwilson deleted the aw/always-create-pr branch May 8, 2019

@smashwilson smashwilson added this to In progress in Release : 9 May 2019 - 5 June 2019 : v0.30.0 via automation Jul 18, 2019

@smashwilson smashwilson referenced this pull request Jul 18, 2019
4 of 4 tasks complete

@smashwilson smashwilson moved this from In progress to Merged in Release : 9 May 2019 - 5 June 2019 : v0.30.0 Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.