Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab styling refactor #2147

Merged
merged 2 commits into from May 14, 2019

Conversation

@vanessayuenn
Copy link
Contributor

commented May 14, 2019

This is a small styling refactor + rename that will make the css classnames more appropriate when they are later re-used in the review dock. Doing this in a separate PR to keep the review authoring PR smaller and scoped.

generalize the classnames used for `github-IssueishDetailView-tab*` t…
…o pave road for usage in review authoring feature
@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #2147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2147   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files         212      212           
  Lines       12171    12171           
  Branches     1779     1779           
=======================================
  Hits        11263    11263           
  Misses        908      908
Impacted Files Coverage Δ
lib/views/pr-detail-view.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a9299e...98d246b. Read the comment docs.

@smashwilson
Copy link
Member

left a comment

👍

@vanessayuenn vanessayuenn merged commit d1d0286 into master May 14, 2019

14 checks passed

atom.github Build #20190514.9 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing 1a9299e...98d246b
Details
codecov/project 92.53% remains the same compared to 1a9299e
Details

@vanessayuenn vanessayuenn deleted the vy/generalize-tab-styling branch May 14, 2019

@smashwilson smashwilson added this to In progress in Release : 9 May 2019 - 5 June 2019 : v0.30.0 via automation Jul 18, 2019

@smashwilson smashwilson referenced this pull request Jul 18, 2019
4 of 4 tasks complete

@smashwilson smashwilson moved this from In progress to Merged in Release : 9 May 2019 - 5 June 2019 : v0.30.0 Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.