Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

:arrow_up: react + react-dom #2150

Merged
merged 1 commit into from May 14, 2019

Conversation

@smashwilson
Copy link
Member

commented May 14, 2019

Upgrade the React dependencies simultaneously. I took this for a spin locally and everything looked good 馃憤

Fixes #2069.
Fixes #2059.

@codecov

This comment has been minimized.

Copy link

commented May 14, 2019

Codecov Report

Merging #2150 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2150      +/-   ##
==========================================
+ Coverage   92.53%   92.54%   +<.01%     
==========================================
  Files         212      212              
  Lines       12171    12171              
  Branches     1779     1779              
==========================================
+ Hits        11263    11264       +1     
+ Misses        908      907       -1
Impacted Files Coverage 螖
lib/atom/gutter.js 92.3% <0%> (+2.56%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update edbb26d...e9dbc8c. Read the comment docs.

@kuychaco
Copy link
Member

left a comment

馃憤 looks good!

@kuychaco kuychaco merged commit 24cded2 into master May 14, 2019

16 of 17 checks passed

Consider pull request for release board Consider pull request for release board
Details
Add pull request to release board Add pull request to release board
Details
Consider pull request for release board Consider pull request for release board
Details
atom.github Build #20190514.13 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch Coverage not affected when comparing edbb26d...e9dbc8c
Details
codecov/project 92.54% (+<.01%) compared to edbb26d
Details

Release : 9 May 2019 - 5 June 2019 : v0.30.0 automation moved this from In progress to Merged May 14, 2019

@kuychaco kuychaco deleted the aw/react-up branch May 14, 2019

@smashwilson smashwilson referenced this pull request Jul 18, 2019
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can鈥檛 perform that action at this time.