Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL schema update #2177

Merged
merged 7 commits into from Jul 6, 2019

Conversation

@github-actions
Copy link

commented Jun 6, 2019

馃 This automated pull request brought to you by a GitHub action 馃

The GraphQL schema has been updated and relay-compiler has been re-run on the package source. relay-compiler failed with the following output:


Writing js
ERROR:
RelayParser: Encountered 2 error(s):
- Unknown field 'timeline' on type 'Issue'. Source: document `issueTimelineController_issue` file: `controllers/issue-timeline-controller.js`
  
  controllers/issue-timeline-controller.js (8:7)
  7:       url
  8:       timeline(
           ^
  9:         first: $timelineCount, after: $timelineCursor
  
- Unknown field 'timeline' on type 'PullRequest'. Source: document `prTimelineController_pullRequest` file: `controllers/pr-timeline-controller.js`
  
  controllers/pr-timeline-controller.js (9:7)
   8:       ...headRefForcePushedEventView_issueish
   9:       timeline(first: $timelineCount, after: $timelineCursor) @connection(key: "prTimelineContainer_timeline") {
            ^
  10:         pageInfo { endCursor hasNextPage }
  

馃毃 Check out this branch to fix things so we don't break. 馃毃

@codecov

This comment has been minimized.

Copy link

commented Jun 6, 2019

Codecov Report

Merging #2177 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
- Coverage   92.72%   92.66%   -0.07%     
==========================================
  Files         215      215              
  Lines       12269    12271       +2     
  Branches     1796     1796              
==========================================
- Hits        11377    11371       -6     
- Misses        892      900       +8
Impacted Files Coverage 螖
lib/controllers/pr-timeline-controller.js 33.33% <酶> (酶) 猬嗭笍
...views/timeline-items/commit-comment-thread-view.js 100% <酶> (酶) 猬嗭笍
lib/controllers/issue-timeline-controller.js 0% <酶> (酶) 猬嗭笍
lib/views/issueish-timeline-view.js 97.91% <100%> (酶) 猬嗭笍
lib/views/timeline-items/commits-view.js 100% <100%> (酶) 猬嗭笍
lib/git-temp-dir.js 90.9% <0%> (-9.1%) 猬囷笍
lib/helpers.js 87.24% <0%> (-1.65%) 猬囷笍
lib/github-package.js 66.79% <0%> (-0.39%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6e2eda2...faa0aa9. Read the comment docs.

@smashwilson

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Here's the breaking change associated with this. Looks like an easy fix:

https://developer.github.com/v4/breaking_changes/#changes-scheduled-for-2019-10-01

smashwilson added some commits Jun 6, 2019

@smashwilson smashwilson merged commit a1e5945 into master Jul 6, 2019

14 of 15 checks passed

Consider pull request for release board Consider pull request for release board
Details
atom.github Build #20190606.10 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux beta) Linux beta succeeded
Details
atom.github (Linux dev) Linux dev succeeded
Details
atom.github (Linux stable) Linux stable succeeded
Details
atom.github (MacOS beta) MacOS beta succeeded
Details
atom.github (MacOS dev) MacOS dev succeeded
Details
atom.github (MacOS stable) MacOS stable succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows beta) Windows beta succeeded
Details
atom.github (Windows dev) Windows dev succeeded
Details
atom.github (Windows stable) Windows stable succeeded
Details
codecov/patch 100% of diff hit (target 92.72%)
Details
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +7.27% compared to 6e2eda2
Details

@smashwilson smashwilson deleted the schema-update/1559782934969 branch Jul 6, 2019

@smashwilson smashwilson added this to In progress in Release : 9 May 2019 - 5 June 2019 : v0.30.0 via automation Jul 18, 2019

@smashwilson smashwilson referenced this pull request Jul 18, 2019
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can鈥檛 perform that action at this time.