Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid stalls caused by large diffs fetched from GitHub #2195
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Interestingly, the stalls seem to be in what-the-diff's PEG parser rather than our own
To mitigate this:
Here's what I'm doing if you open an editor on a file that has review comments, but whose patch has been omitted for size:
Using Atom to edit files on branches corresponding to pull requests with "large" diffs will no longer cause periodic stalls.
The review comment and patch fetches can happen in parallel presently because they're independent operations. By making the patch fetch depend on the result of the review comment aggregation, it'll take longer to load all of the data and display the first review comment decoration or populate the reviews tab.
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #2195 +/- ## ========================================= - Coverage 92.72% 92.7% -0.02% ========================================= Files 215 216 +1 Lines 12269 12350 +81 Branches 1796 1814 +18 ========================================= + Hits 11376 11449 +73 - Misses 893 901 +8
Lol okay then: