Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize comment path #2305

Merged
merged 2 commits into from Oct 11, 2019
Merged

Normalize comment path #2305

merged 2 commits into from Oct 11, 2019

Conversation

@wadethestealth
Copy link
Contributor

wadethestealth commented Oct 11, 2019

This fixes #2302, where loading review comments was causing an error because the comment path and translation path were using opposite slashes for the file path.

  • updates test cases

Fixes #2302

❤️ @rsese @smashwilson

@wadethestealth

This comment has been minimized.

Copy link
Contributor Author

wadethestealth commented Oct 11, 2019

Updating this existing beforeEach build is enough to fail pre-patch code (only on windows, which is the only place the bug exists too), however when it fails they will see a stack trace that looks identical to #2302. So, I have not technically created a test case, but can if you want.

Copy link
Member

smashwilson left a comment

Works for me. Thanks!

@@ -235,7 +235,7 @@ describe('ReviewsView', function() {
.addReviewThread(t => {
t.thread(t0 => t0.id('abcd'));
t.addComment(c =>
c.id(0).path('dir/file0').position(10).bodyHTML('i have opinions.').author(a => a.login('user0').avatarUrl('user0.jpg')),
c.id(0).path('dir/file0').position(10).bodyHTML('i have a bad windows file path.').author(a => a.login('user0').avatarUrl('user0.jpg')),

This comment has been minimized.

Copy link
@smashwilson
@smashwilson smashwilson merged commit e581524 into atom:master Oct 11, 2019
6 checks passed
6 checks passed
atom.github Build #20191011.2 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
@wadethestealth wadethestealth deleted the wadethestealth:fix-#2302 branch Oct 17, 2019
@lkashef lkashef mentioned this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.