Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JavaScript scripts for npm test tasks #2311

Merged
merged 2 commits into from Oct 17, 2019
Merged

Use JavaScript scripts for npm test tasks #2311

merged 2 commits into from Oct 17, 2019

Conversation

@smashwilson
Copy link
Member

smashwilson commented Oct 17, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Replace the cross-env-shell tasks in package.json with proper Node.js scripts.

Screenshot/Gif

Alternate Designs

N/A

Benefits

Unit tests and code coverage will be able to run on Windows. Set ATOM_SCRIPT_PATH to run tests with an alternate Atom binary, like atom-nightly or atom-dev.

Possible Drawbacks

It's wordier this way, and possibly slightly less efficient.

Applicable Issues

Fixes #2309.

Metrics

N/A

Tests

I successfully ran npm test, npm run test:coverage, and npm run test:snapshot on my Windows 10 box. I've verified that the exit status is propagated correctly (0 on test success, 1 on test failure).

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

smashwilson added 2 commits Oct 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #2311 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
+ Coverage    93.3%   93.31%   +<.01%     
==========================================
  Files         228      228              
  Lines       12893    12893              
  Branches     1847     1847              
==========================================
+ Hits        12030    12031       +1     
+ Misses        863      862       -1
Impacted Files Coverage Δ
lib/atom/gutter.js 92.85% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e581524...b778f2d. Read the comment docs.

@smashwilson smashwilson merged commit 57788ea into master Oct 17, 2019
8 checks passed
8 checks passed
atom.github Build #20191017.4 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing e581524...b778f2d
Details
codecov/project 93.31% (+<.01%) compared to e581524
Details
@smashwilson smashwilson deleted the aw/fix-npm-test branch Oct 17, 2019
@wadethestealth

This comment has been minimized.

Copy link
Contributor

wadethestealth commented Oct 17, 2019

❤️

@smashwilson smashwilson mentioned this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.