Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push using GITHUB_ACTOR and GITHUB_TOKEN #2312

Merged
merged 2 commits into from Oct 17, 2019
Merged

Push using GITHUB_ACTOR and GITHUB_TOKEN #2312

merged 2 commits into from Oct 17, 2019

Conversation

@smashwilson
Copy link
Member

smashwilson commented Oct 17, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Attempt to fix the automatic GraphQL schema workflow by explicitly using ${GITHUB_ACTOR} and ${GITHUB_TOKEN} as push credentials.

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Our local copy of the GraphQL schema will be kept up to date automatically, and we'll have early warnings about any deprecations that may impact the GitHub package.

Possible Drawbacks

N/A

Applicable Issues

N/A

Metrics

N/A

Tests

Unfortunately we can't really test this out until the next time the scheduled job fires. I'm going to change it to run tonight to give it a shot.

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

smashwilson added 2 commits Oct 17, 2019
@smashwilson smashwilson marked this pull request as ready for review Oct 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #2312 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
+ Coverage   93.31%   93.32%   +<.01%     
==========================================
  Files         228      228              
  Lines       12893    12893              
  Branches     1847     1847              
==========================================
+ Hits        12031    12032       +1     
+ Misses        862      861       -1
Impacted Files Coverage Δ
lib/controllers/root-controller.js 83.91% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0ab6f...1bbfbd9. Read the comment docs.

@smashwilson smashwilson merged commit c8a1fb0 into master Oct 17, 2019
8 checks passed
8 checks passed
atom.github Build #20191017.9 had test failures
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing bb0ab6f...1bbfbd9
Details
codecov/project 93.32% (+<.01%) compared to bb0ab6f
Details
@smashwilson smashwilson deleted the aw/schema-update branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.