Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed jump to file from options when viewing past commits #2324

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@darangi
Copy link
Contributor

darangi commented Oct 25, 2019

Description of the Change

Removed jump to file from the list of options when viewing a past commit or a diff.

Possible Drawbacks

None.

Applicable Issues

Fixes #2310

Copy link
Member

smashwilson left a comment

👍 Yah, good call.

I'd love to get this to actually work at some point. But there are a ton of edge cases we'd need to account for.

@smashwilson smashwilson merged commit 77414e9 into atom:master Oct 28, 2019
6 checks passed
6 checks passed
atom.github Build #20191025.16 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
@darangi

This comment has been minimized.

Copy link
Contributor Author

darangi commented Oct 28, 2019

👍 Yah, good call.

I'd love to get this to actually work at some point. But there are a ton of edge cases we'd need to account for.

At some point in the future, we will look into this 👍

@lkashef lkashef mentioned this pull request Nov 6, 2019
@wadethestealth

This comment has been minimized.

Copy link
Contributor

wadethestealth commented Nov 21, 2019

@smashwilson @darangi @lkashef This should also close #2098. Can one of you close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.