Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Blank states for GitHub tab #2329
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Description of the Change
Implement the "blank" states of the GitHub tab when:
I'm doing this by keying off of the active Repository's state in GitHubTabView, and launching the dialogs introduced in #2222.
See the feature request.
Users will no longer be presented with a blank, featureless tab if they open the GitHub tab without any repositories open (
We still don't handle Enterprise, which means that you could have a remote pointing to an Enterprise instance and we'll still tell you we don't have any GitHub remotes. Accurate, but frustrating.
Feature request: #2111.
Standard unit test coverage.
Flight manual documentation of the new path to the Clone dialog: atom/flight-manual.atom.io#573
User Experience Research (Optional)
@@ Coverage Diff @@ ## master #2329 +/- ## ========================================== + Coverage 93.26% 93.28% +0.01% ========================================== Files 230 231 +1 Lines 12949 12979 +30 Branches 1849 1851 +2 ========================================== + Hits 12077 12107 +30 Misses 872 872
Nah. Sadly, it's all manual.
The fix there is to migrate to using hooks, which allow us to gracefully consume multiple contexts in the same component. But that effort is waiting for either (i) Enzyme to support hooks in its shallow renderer, or (ii) a gradual rework of the test suite to use mount() instead. See #1437 for some discussion and links to draft implementations of alternatives that we've explored in the past.
It's because of the way we're using Azure DevOps and its CodeCov reporter. For some reason, we only get coverage data and the coverage change comment when we have both "push" builds and "pull request" builds. When you make pull requests from a fork, only the "pull request" build runs.
If I can work it out, I can try to tackle that as part of #2298.