Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action maintenance #2341

Merged
merged 2 commits into from Nov 8, 2019
Merged

GitHub Action maintenance #2341

merged 2 commits into from Nov 8, 2019

Conversation

@smashwilson
Copy link
Member

smashwilson commented Nov 8, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Upgrade some dependencies on the GitHub action we use to automatically keep the GraphQL schema up to date (but not relay-compiler, until I upgrade Relay dependencies across the board). Use tools.exit.success() instead of tools.exit.neutral() because "neutral" exits aren't supported by Actions v2.

Screenshot

N/A

Alternate Designs

N/A

Benefits

We won't get statuses on master commits when the scheduled schema update job runs and doesn't have anything to do.

Possible Drawbacks

N/A

Applicable Issues

N/A

Metrics

N/A

Tests

We'll see if it works if I don't get an email next week 🙃

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

smashwilson added 2 commits Nov 8, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #2341 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   93.27%   93.28%   +<.01%     
==========================================
  Files         231      231              
  Lines       12979    12979              
  Branches     1851     1851              
==========================================
+ Hits        12106    12107       +1     
+ Misses        873      872       -1
Impacted Files Coverage Δ
lib/atom/gutter.js 92.85% <0%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff6991...557c8c9. Read the comment docs.

@smashwilson smashwilson merged commit 2f6959d into master Nov 8, 2019
8 checks passed
8 checks passed
atom.github Build #20191108.16 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing cff6991...557c8c9
Details
codecov/project 93.28% (+<.01%) compared to cff6991
Details
@smashwilson smashwilson deleted the aw/action-maintenance branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.