Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sync electron-link and electron-mksnapshot with atom/atom #2365

Merged
merged 4 commits into from Dec 11, 2019

Conversation

@smashwilson
Copy link
Member

smashwilson commented Dec 10, 2019

Looks like the versions of electron-link and electron-mksnapshot that we use to verify snapshottability in our CI builds have drifted from the ones in Atom:

https://github.com/atom/atom/blob/f0e4ca6d5d55f2422c107fcea93edba10ce816ac/script/package.json#L14-L15

Let's re-sync and fix any issues that have arisen in the meantime.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #2365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2365   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         235      235           
  Lines       13066    13066           
  Branches     1859     1859           
=======================================
  Hits        12209    12209           
  Misses        857      857

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f818ed...5219ab8. Read the comment docs.

@smashwilson

This comment has been minimized.

Copy link
Member Author

smashwilson commented Dec 11, 2019

Turns out any Relay version newer than 5.0.0 segfaults mksnapshot. I have no idea why 🤔

smashwilson added 2 commits Dec 11, 2019
@smashwilson smashwilson merged commit fcdc5d9 into master Dec 11, 2019
8 checks passed
8 checks passed
atom.github #20191211.7 succeeded
Details
atom.github (Lint) Lint succeeded
Details
atom.github (Linux) Linux succeeded
Details
atom.github (MacOS) MacOS succeeded
Details
atom.github (Snapshot) Snapshot succeeded
Details
atom.github (Windows) Windows succeeded
Details
codecov/patch Coverage not affected when comparing 3f818ed...5219ab8
Details
codecov/project 93.44% remains the same compared to 3f818ed
Details
@smashwilson smashwilson deleted the sync-electron-link branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.