Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI host images #2427

Merged
merged 4 commits into from Apr 4, 2020
Merged

Bump CI host images #2427

merged 4 commits into from Apr 4, 2020

Conversation

smashwilson
Copy link
Member

@smashwilson smashwilson commented Apr 4, 2020

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Get the Windows and macOS CI builds working again by bumping their CI host images to supported ones .

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

We'll get more assurances that we aren't introducing cross-platform incompatibilities as we merge PRs.

Possible Drawbacks

N/A

Applicable Issues

N/A

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #2427 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2427      +/-   ##
==========================================
+ Coverage   93.07%   93.37%   +0.29%     
==========================================
  Files         235      235              
  Lines       13178    13178              
  Branches     1892     1892              
==========================================
+ Hits        12266    12305      +39     
+ Misses        912      873      -39     
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 99.80% <0.00%> (+0.57%) ⬆️
lib/helpers.js 89.30% <0.00%> (+2.88%) ⬆️
lib/models/file-system-change-observer.js 96.00% <0.00%> (+8.00%) ⬆️
lib/shared/keytar-strategy.js 58.13% <0.00%> (+19.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b0925...3ac0a28. Read the comment docs.

@smashwilson smashwilson merged commit c11d582 into master Apr 4, 2020
2 checks passed
@smashwilson smashwilson deleted the make-ci-work branch Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant