This repository has been archived by the owner. It is now read-only.

fix tooltip destroy error #54

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@UziTech
Contributor

UziTech commented Mar 23, 2018

Description of the Change

fixes this error

image

Alternate Designs

Benefits

no error on destroy

Possible Drawbacks

none

Applicable Issues

@UziTech UziTech changed the title from fix tooltip distroy error to fix tooltip destroy error Mar 23, 2018

@50Wliu 50Wliu merged commit f250c17 into atom:master Mar 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Arcanemagus

This comment has been minimized.

Arcanemagus commented Apr 5, 2018

For reference, here is some nice searchable text for the error so nobody else starts to file the issue like I just did only to find it's already been fixed 😆

Error deactivating package 'grammar-selector' TypeError: this.tooltip.destroy is not a function
    at GrammarStatusView.destroy (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\node_modules\grammar-selector\lib\grammar-status-view.js:60:26)
    at Object.deactivate (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\node_modules\grammar-selector\lib\main.js:20:52)
    at Package.deactivate (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\package.js:708:58)
    at PackageManager.deactivatePackage (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\package-manager.js:776:43)
    at Promise.all.getLoadedPackages.map.pack (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\package-manager.js:759:67)
    at Array.map (native)
    at config.transactAsync (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\package-manager.js:759:50)
    at Config.transactAsync (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\config.js:866:28)
    at PackageManager.deactivatePackages (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\package-manager.js:758:29)
    at disposables.add.applicationDelegate.onDidRequestUnload (C:\Users\abneyl\AppData\Local\atom\app-1.26.0-beta1\resources\app\src\atom-environment.js:825:48)
    at <anonymous>

Thanks for the PR @UziTech!

@50Wliu

This comment has been minimized.

Member

50Wliu commented Apr 6, 2018

Oh, I forgot to create a new version! I'll do that shortly.

@UziTech UziTech referenced this pull request Apr 11, 2018

Closed

Closing window bug #146

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.