New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit `destroy` event like promised #180

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@Aerijo
Contributor

Aerijo commented Aug 1, 2018

Description of the Change

Make it emit the did-destroy event like the inline doc comments say can be expected. I don't actually know how someone would access that method, but seems reasonable to have (and is consistent with many other API methods in Atom).

Applicable Issues

Fixes #177

@lee-dohm lee-dohm merged commit 9282d8b into atom:master Aug 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Aug 6, 2018

Member

Thanks for the help!

Member

lee-dohm commented Aug 6, 2018

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment