Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #186

Merged
merged 12 commits into from Dec 28, 2018

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

50Wliu commented Dec 28, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Converts the remaining CoffeeScript files to JavaScript, removes Babel and underscore-plus usage, lints with Standard, and uses async/await in specs.

I also caught and fixed two incorrect instanceof assertions that were revealed by this conversion.

Alternate Designs

None.

Benefits

Modernizes the codebase.

Possible Drawbacks

Unintended regressions caused by code conversion.

Applicable Issues

None.

50Wliu added some commits Dec 28, 2018

@50Wliu 50Wliu merged commit 1fddc24 into master Dec 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-modernize branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.