Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Description of the Change
Converts the Keybinding Resolver into a Dock. This fixes some usability issues with the resolver, such as:
And adds a nice styling touch to make the header sticky.
I don't foresee any. This should strictly be an upgrade from the existing panel, though I may be missing something. One small thing is that after using the resolver, you might be inclined to close the dock instead of the keybinding resolver. In that case the resolver will still be active and continue to track and display keybindings, resulting in a small performance penalty.
Most of the boilerplate code was copied from the active-editor-info example package. I don't want to needlessly ping someone, but thanks a lot
Yay for no more jumping..
Added some small restyling:
The header background could be changed to look seamless to the tab, but that's something themes have to look into.
Do Docks have some sort of "only run if dock item is visible" option? Maybe ::isVisible()? So that it can be paused while the dock item is hidden.
fwiw, my merge is here, https://github.com/bdowling/keybinding-resolver/tree/add_copy_keybinding_with_pr58 -- it's been working well for me, other than the minor conflicts, not sure what else this PR needs to get accepted, but I like it. Thanks!