Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #64

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@macklinu
Copy link
Contributor

commented Sep 12, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

When cloning the repo and running npm install (with npm@6.4.1), package-lock.json changes which version of etch is resolved. package.json states 0.9.0, whereas package-lock.json was resolving 0.14.0. I think this is the correct change (lock to etch@0.9.0) by looking at commit history.

If this isn't the correct change or there is something else I can help out with here, please let me know.

Alternate Designs

N/A

Benefits

This could help ensure the desired version of etch is installed when running npm install.

Possible Drawbacks

N/A

Applicable Issues

N/A

Update package-lock.json
When cloning the repo and running `npm install`, package-lock.json
changes which version of etch is resolved. package.json states 0.9.0,
whereas package-lock.json was resolving 0.14.0. I think this is the
correct change (lock to etch@0.9.0) by looking at commit history.

@50Wliu 50Wliu merged commit 03276b7 into atom:master Sep 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.