New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope primitive types as support.storage.type instead of support.support.type #302

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@Ben3eeE
Member

Ben3eeE commented Oct 31, 2018

Refs #299 (comment)

The ones that work with fizzy are support.storage.type instead of support.support.type.

/cc: @maxbrunsfeld I didn't test this change in Atom other than looking at the scopes in Atom and which are highlighted with fizzy. I'll test this out later today when I can link packages into Atom.

Ben3eeE added some commits Oct 31, 2018

Show resolved Hide resolved grammars/tree-sitter-cpp.cson Outdated
@@ -140,7 +140,7 @@ scopes:
'"unsigned"': 'support.storage.type'
'"short"': 'support.storage.type'
'"long"': 'support.storage.type'
'auto': 'storage.storage.type'
'auto': 'support.storage.type'

This comment has been minimized.

@Ben3eeE

Ben3eeE Oct 31, 2018

Member

Not sure why this isn't wrapped in "". Is auto not an anonymous node?

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Oct 31, 2018

Fizzy with this PR:
image

Fizzy without this PR:
image

Atom Dark Fusion with this PR:
image

Atom Dark Fusion without this PR:
image

In other themes I have installed I didn't see any difference between this PR and master.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Oct 31, 2018

And what about One Dark and One Light? My only concern with this is that I like the current behavior on the built-in themes - all types get highlighted the same, as opposed to primitives being highlighted in purple just like if, else, etc.

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Oct 31, 2018

Oops should have mentioned I tested one dark/light as well to not change this behavior:

c++
image

c
image

Atom material is the same where primitive types are a different color
image

if being cursive is because of my personal stylesheet.

@Ben3eeE

This comment has been minimized.

Member

Ben3eeE commented Oct 31, 2018

Oh and both one-dark/light and atom material look the same with or without this change.

@maxbrunsfeld

This comment has been minimized.

Contributor

maxbrunsfeld commented Oct 31, 2018

Nice! Thanks @Ben3eeE 🙏

@Ben3eeE Ben3eeE merged commit 548cab6 into master Oct 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ben3eeE Ben3eeE deleted the b3-fix-types branch Oct 31, 2018

@Ben3eeE Ben3eeE referenced this pull request Oct 31, 2018

Merged

:arrow_up: languages #18374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment