Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added noexcept and mutable, removed _Atomic from tree-sitter-cpp #331

Merged
merged 3 commits into from Jun 14, 2019
Merged

Added noexcept and mutable, removed _Atomic from tree-sitter-cpp #331

merged 3 commits into from Jun 14, 2019

Conversation

@isaacsaffold
Copy link
Contributor

@isaacsaffold isaacsaffold commented Jun 13, 2019

Description of the Change

noexcept and mutable were added to storage.modifier in "tree-sitter-cpp.cson", corresponding with their presence in "c++.cson". _Atomic, which is a valid type qualifier in C but not C++, was removed from "tree-sitter-cpp.cson".

Benefits

noexcept and mutable will be highlighted correctly, and any confusion caused by _Atomic being erroneously highlighted will cease.

@Ben3eeE Ben3eeE self-requested a review Jun 13, 2019
@Ben3eeE
Copy link
Member

@Ben3eeE Ben3eeE commented Jun 13, 2019

👋 Thanks for contributing.

noexcept is being added in #330 which brings improved support for it from the tree-sitter upgrade.

Though I realize the scopes I added for noexcept are wrong. Do you mind undoing the noexcept change here and I correct it in my PR?

Loading

@isaacsaffold
Copy link
Contributor Author

@isaacsaffold isaacsaffold commented Jun 13, 2019

I just undid it.

Loading

@Ben3eeE Ben3eeE merged commit 3cd4db6 into atom:master Jun 14, 2019
1 check passed
Loading
@Ben3eeE
Copy link
Member

@Ben3eeE Ben3eeE commented Jun 14, 2019

Thanks for contributing 🙇

Loading

@isaacsaffold
Copy link
Contributor Author

@isaacsaffold isaacsaffold commented Jun 14, 2019

No problem. Glad I could be of service.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants