New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp embedded JS patterns #147

merged 1 commit into from Sep 19, 2017


None yet
1 participant

50Wliu commented Sep 18, 2017


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Clamps embedded JS patterns to always end at `.

Alternate Designs

A multiline pattern could be kept but with an additional subpattern specifically targeting JS comments, as is done in HTML.


No runaway JS code.

Possible Drawbacks

Multiline embedded JS is no longer possible.

Applicable Issues

Fixes #146

@50Wliu 50Wliu merged commit e432aa6 into master Sep 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-clamp-embedded-js branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment