New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block comments are not necessarily multiline #150

Merged
merged 2 commits into from Sep 19, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Sep 19, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This removes the pattern that was forcing block comments to always be multiline. However, doing so has exposed more bugs with function tokenization breaking on comments. I'll see if it can be fixed in this PR.

Alternate Designs

N/A

Benefits

Single-line block comments will be tokenized correctly.

Possible Drawbacks

There are no drawbacks, per say, but as mentioned above this change does reveal some more underlying bugs.

Applicable Issues

Fixes #149

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 19, 2017

Member

At first glance, it will require an extremely substantial amount of effort to get those patterns to tokenize correctly. Merging this as it still fixes the issue.

Member

50Wliu commented Sep 19, 2017

At first glance, it will require an extremely substantial amount of effort to get those patterns to tokenize correctly. Merging this as it still fixes the issue.

@50Wliu 50Wliu merged commit 6e71250 into master Sep 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-allow-single-line-extended-comments branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment